Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_vpc_igw: fix 'NoneType' object is not subscriptable (#691) #697

Merged
merged 1 commit into from
Mar 11, 2022
Merged

ec2_vpc_igw: fix 'NoneType' object is not subscriptable (#691) #697

merged 1 commit into from
Mar 11, 2022

Conversation

alinabuzachis
Copy link
Collaborator

Manual backport to stable-3: ec2_vpc_igw: fix 'NoneType' object is not subscriptable

SUMMARY
Add "InternetGatewayAttached" waiter
Fixes #647
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vpc_igw

Reviewed-by: Alina Buzachis
Reviewed-by: Joseph Torcasso
Reviewed-by: Jill R
Reviewed-by: Abhijeet Kasurde
(cherry picked from commit 8cc9397)

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@jatorcasso @alinabuzachis
ec2_vpc_igw: fix 'NoneType' object is not subscriptable (ansible-coll…
8bde18f 
…ections#691)

ec2_vpc_igw: fix 'NoneType' object is not subscriptable

Depends-On: ansible/ansible-zuul-jobs#1368
SUMMARY
Add "InternetGatewayAttached" waiter
Fixes ansible-collections#647
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_vpc_igw

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
Reviewed-by: Abhijeet Kasurde <None>
(cherry picked from commit 8cc9397)
@ansibullbot
Copy link

cc @jillr @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module module_utils module_utils needs_triage plugins plugin (any type) labels Mar 4, 2022
@alinabuzachis
Copy link
Collaborator Author

Since #691 has not been backported, the backport for #695 has failed. We need to merge this first and then do a manual backport for #695

@alinabuzachis alinabuzachis requested a review from jillr March 4, 2022 13:22
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Mar 11, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 72378dc into ansible-collections:stable-3 Mar 11, 2022
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@ansible-zuul
Merge pull request ansible-collections#697 from mandar242/issues-204-…
24940d4 
…update-iam-role

iam_role: replace UpdateRoleDescription with use UpdateRole

SUMMARY

Modified iam_role.py to replace update_role_description (deprecated) with update_role action call.

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

iam_role

Reviewed-by: Mark Chappell <None>
Reviewed-by: Jill R <None>
Reviewed-by: None <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr Awaiting requested review from jillr

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module_utils module_utils module module needs_triage plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alinabuzachis @ansibullbot @jatorcasso